From 73b97760ea12f8efcd8f538f7f50627f6df5f7a6 Mon Sep 17 00:00:00 2001 From: Robert Pengelly Date: Wed, 1 Oct 2025 12:12:08 +0100 Subject: [PATCH] Don't forget to cast --- lib.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/lib.c b/lib.c index d6897a7..525a0b6 100755 --- a/lib.c +++ b/lib.c @@ -203,7 +203,7 @@ void parse_args (int argc, char **argv, int optind) { unsigned long array_to_integer (unsigned char *arr, int size, int bigendian) { - unsigned long val = 0, mask = 1; + unsigned long val = 0; int i; if (bigendian) { @@ -211,24 +211,18 @@ unsigned long array_to_integer (unsigned char *arr, int size, int bigendian) { int j; for (i = size, j = 0; i > 0; i--, j++) { - - mask *= (UCHAR_MAX + 1); - val |= arr[j] << (CHAR_BIT * (i - 1)); - + val |= (unsigned long) arr[j] << (CHAR_BIT * (i - 1)); } } else { for (i = 0; i < size; i++) { - - mask *= (UCHAR_MAX + 1); - val |= arr[i] << (CHAR_BIT * i); - + val |= (unsigned long) arr[i] << (CHAR_BIT * i); } } - return val & (mask - 1); + return val; } -- 2.34.1